Skip to content

fix(amazonq): remove profile validation #7615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

fix(amazonq): remove profile validation #7615

merged 1 commit into from
Jul 7, 2025
+0 −32

Conversation

@tsmithsz
Copy link
Contributor

@tsmithsz tsmithsz commented Jul 7, 2025 •
edited
Loading

Problem

VS Code extension startup was delayed by ~5 seconds due to profile validation logic that used jittered API calls to avoid rate limiting. This cross-validation checked if restored profiles were still valid but caused poor user experience during plugin loading.

Related PR:

Solution

Removed the profile cross-validation code in restoreRegionProfile() to eliminate startup delays. This trades off immediate detection of admin-deleted profiles (rare edge case) for faster plugin loading that benefits all users daily.

Testing

Generate plugin build and tested. Saw latency improvements of ~2-3s in plugin load time

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tsmithsz tsmithsz requested a review from a team as a code owner July 7, 2025 18:17
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@tsmithsz tsmithsz merged commit 2cc1a26 into aws:master Jul 7, 2025
31 checks passed
@Will-ShaoHua Will-ShaoHua changed the title fix(amazonq): remove jitter for validation call of profiles fix(amazonq): remove profile validation Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsmithsz @Will-ShaoHua